From 2ae99e2636896b17ce9bf7d4707f533dd24aa445 Mon Sep 17 00:00:00 2001
From: Paul Pan <panyuxuan@hotmail.com>
Date: Mon, 26 Sep 2022 17:15:31 +0800
Subject: [PATCH] fix: middleware now record real success info

---
 internal/e/resp.go                 | 1 +
 internal/pkg/metrics/middleware.go | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/internal/e/resp.go b/internal/e/resp.go
index 25da040..b3a8e4c 100644
--- a/internal/e/resp.go
+++ b/internal/e/resp.go
@@ -21,5 +21,6 @@ func Wrap(status Status, body interface{}) interface{} {
 }
 
 func Pong(c *gin.Context, status Status, body interface{}) {
+	c.Set("err", status)
 	c.JSON(http.StatusOK, Wrap(status, body))
 }
diff --git a/internal/pkg/metrics/middleware.go b/internal/pkg/metrics/middleware.go
index 679c322..e1fd20e 100644
--- a/internal/pkg/metrics/middleware.go
+++ b/internal/pkg/metrics/middleware.go
@@ -34,6 +34,8 @@ func (m *Metrics) Handler() gin.HandlerFunc {
 		if !ok {
 			success = false
 			err = e.Unknown
+		} else if err != e.Success {
+			success = false
 		}
 
 		m.Record(method, url, success, status, err, elapsed)