woj/nsjail
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix default rlimit_stack value

Browse Source 
The default `rlimit_stack` value was set to 1048576. However, this value is in MiB and so is later multiplied by 1024*1024 in b3d544d155/config.cc (L161-L162) and it ends up as a limit of 1 TB for the stack size.

This PR changes it to 8 MB which is a more sane default or, at least I took it from my virtual machine's ulimits:
```
$ ulimit -a
core file size          (blocks, -c) 0
data seg size           (kbytes, -d) unlimited
scheduling priority             (-e) 0
file size               (blocks, -f) unlimited
pending signals                 (-i) 31175
max locked memory       (kbytes, -l) 16384
max memory size         (kbytes, -m) unlimited
open files                      (-n) 1024
pipe size            (512 bytes, -p) 8
POSIX message queues     (bytes, -q) 819200
real-time priority              (-r) 0
stack size              (kbytes, -s) 8192
cpu time               (seconds, -t) unlimited
max user processes              (-u) 31175
virtual memory          (kbytes, -v) unlimited
file locks                      (-x) unlimited
```
This commit is contained in:
Disconnect3d 2019-12-07 17:05:45 +01:00 committed by GitHub
parent 1111bb135a
commit 7f9ed1ba12
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config.proto
View File

@ -157,7 +157,7 @@ message NsJailConfig {
optional uint64 rlimit_nproc = 38 [default = 1024];
optional RLimit rlimit_nproc_type = 39 [default = SOFT];
/* In MiB, use the soft limit value by default */
optional uint64 rlimit_stack = 40 [default = 1048576];
optional uint64 rlimit_stack = 40 [default = 8];
optional RLimit rlimit_stack_type = 41 [default = SOFT];
/* Disable all rlimits, default to limits set by parent */