From db210fbc66ca779a7bc6748cd340cf5eab3de6d4 Mon Sep 17 00:00:00 2001 From: Xu Jun <693788454@qq.com> Date: Thu, 7 Jul 2022 13:53:50 +0800 Subject: [PATCH] Remove unnecessary memset after mmap (#1273) Remove unnecessary memset after mmap to decrease the number of page faults, as reported in #1269. --- core/iwasm/aot/aot_runtime.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/iwasm/aot/aot_runtime.c b/core/iwasm/aot/aot_runtime.c index 64024ce0..3a608117 100644 --- a/core/iwasm/aot/aot_runtime.c +++ b/core/iwasm/aot/aot_runtime.c @@ -525,7 +525,8 @@ memory_instantiate(AOTModuleInstance *module_inst, AOTModule *module, os_munmap(mapped_mem, map_size); return NULL; } - memset(p, 0, (uint32)total_size); + /* Newly allocated pages are filled with zero by the OS, we don't fill it + * again here */ #endif /* end of OS_ENABLE_HW_BOUND_CHECK */ memory_inst->module_type = Wasm_Module_AoT;