From 3693cbe54db6cee3fedccd0d5666ffa430bcfb0b Mon Sep 17 00:00:00 2001 From: Hiroshi Hatake Date: Fri, 23 Sep 2022 11:34:47 +0900 Subject: [PATCH] Suppress hadolint warnings for pinning versions part (#1511) Related to https://github.com/bytecodealliance/wasm-micro-runtime/issues/1418. Suppress hadolint warnings for pinning version. This is because these warnings are for reproducible builds. But for development and CIs, ordinary case developers have to use the latest packages. --- .devcontainer/Dockerfile | 8 ++++++-- test-tools/IoT-APP-Store-Demo/wasm_django/Dockerfile | 2 +- test-tools/wamr-ide/WASM-Debug-Server/Docker/Dockerfile | 1 + test-tools/wamr-ide/WASM-Toolchain/Docker/Dockerfile | 2 ++ 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 89249f1b..5ddba8f3 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -9,6 +9,7 @@ FROM mcr.microsoft.com/vscode/devcontainers/cpp:0-${VARIANT} ARG DEBIAN_FRONTEND=noninteractive ENV TZ=Asian/Shanghai +# hadolint ignore=DL3008 RUN apt-get update \ && apt-get install -y apt-transport-https apt-utils build-essential \ ca-certificates curl g++-multilib git gnupg \ @@ -17,11 +18,12 @@ RUN apt-get update \ software-properties-common tree tzdata \ unzip valgrind vim wget zip --no-install-recommends \ && apt-get clean -y \ - && rm -rf /var/lib/apt/lists/* + && rm -rf /var/lib/apt/lists/* # # CMAKE (https://apt.kitware.com/) SHELL ["/bin/bash", "-o", "pipefail", "-c"] +# hadolint ignore=DL3008 RUN wget --progress=dot:giga -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /usr/share/keyrings/kitware-archive-keyring.gpg > /dev/null \ && echo 'deb [signed-by=/usr/share/keyrings/kitware-archive-keyring.gpg] https://apt.kitware.com/ubuntu/ bionic main' | tee /etc/apt/sources.list.d/kitware.list >/dev/null \ && apt-get update \ @@ -84,13 +86,15 @@ RUN wget --progress=dot:giga https://apt.llvm.org/llvm.sh \ # # Install pip +# hadolint ignore=DL3008 RUN apt-get update \ && apt-get install -y --reinstall python3-venv python3-pip --no-install-recommends \ && apt-get clean -y \ - && rm -rf /var/lib/apt/lists/* + && rm -rf /var/lib/apt/lists/* # # Install required python packages +# hadolint ignore=DL3013 RUN python3 -m pip install --no-cache-dir --upgrade pip \ && pip3 install --no-cache-dir --user black nose pycparser pylint diff --git a/test-tools/IoT-APP-Store-Demo/wasm_django/Dockerfile b/test-tools/IoT-APP-Store-Demo/wasm_django/Dockerfile index 5430ab8d..a796725f 100644 --- a/test-tools/IoT-APP-Store-Demo/wasm_django/Dockerfile +++ b/test-tools/IoT-APP-Store-Demo/wasm_django/Dockerfile @@ -3,7 +3,7 @@ FROM python:3.5 WORKDIR /app COPY . /app +# hadolint ignore=DL3013 RUN pip install django --no-cache-dir ENTRYPOINT ["python", "manage.py", "runserver", "0.0.0.0:80"] - diff --git a/test-tools/wamr-ide/WASM-Debug-Server/Docker/Dockerfile b/test-tools/wamr-ide/WASM-Debug-Server/Docker/Dockerfile index 2c4cb5b5..20e0be55 100644 --- a/test-tools/wamr-ide/WASM-Debug-Server/Docker/Dockerfile +++ b/test-tools/wamr-ide/WASM-Debug-Server/Docker/Dockerfile @@ -8,6 +8,7 @@ WORKDIR /root/ COPY resource /root/ ## - download cmake with wget and set up +# hadolint ignore=DL3008 RUN wget --progress=dot:giga https://github.com/Kitware/CMake/releases/download/v3.21.1/cmake-3.21.1-linux-x86_64.tar.gz \ && tar -zxvf cmake-3.21.1-linux-x86_64.tar.gz \ && rm -f cmake-3.21.1-linux-x86_64.tar.gz \ diff --git a/test-tools/wamr-ide/WASM-Toolchain/Docker/Dockerfile b/test-tools/wamr-ide/WASM-Toolchain/Docker/Dockerfile index 739b0d14..f96a2261 100644 --- a/test-tools/wamr-ide/WASM-Toolchain/Docker/Dockerfile +++ b/test-tools/wamr-ide/WASM-Toolchain/Docker/Dockerfile @@ -10,6 +10,7 @@ WORKDIR /root/ COPY resource /root/ ## - download cmake with wget and set up +# hadolint ignore=DL3008 RUN wget --progress=dot:giga https://github.com/Kitware/CMake/releases/download/v3.21.1/cmake-3.21.1-linux-x86_64.tar.gz \ && tar -zxvf cmake-3.21.1-linux-x86_64.tar.gz \ && rm -f cmake-3.21.1-linux-x86_64.tar.gz \ @@ -66,6 +67,7 @@ COPY --from=BASE /root/build_wasm.sh ${HOME_DIR} RUN ln -s /opt/cmake/bin/cmake /usr/bin/cmake \ && ln -s ${HOME_DIR}/wamrc /usr/bin/wamrc +# hadolint ignore=DL3008 RUN apt-get update && apt-get install -y make --no-install-recommends \ && apt-get clean -y \ && rm -rf /var/lib/apt/lists/*